Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

TAJO-934: Multiple DISTINCT returns null grouping key value.#63

Closed
babokim wants to merge 4 commits into
apache:masterfrom
babokim:TAJO-934
Closed

TAJO-934: Multiple DISTINCT returns null grouping key value.#63
babokim wants to merge 4 commits into
apache:masterfrom
babokim:TAJO-934

Conversation

@babokim
Copy link
Copy Markdown
Contributor

@babokim babokim commented Jul 10, 2014

No description provided.

@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jul 11, 2014

+1

LGTM! I've changed some comments.

@babokim
Copy link
Copy Markdown
Contributor Author

babokim commented Jul 11, 2014

hyunsik please wait a while. I find another bug about multiple distinct.
The following query is recognized as a general group by query not a distinct group by query.
select count(distinct col1) + count(distinct col2) from table1

I'll fix this bug in this patch.

fix the bug which a query whih arithmetics operator is recognized as a general group by query not a distinct group by query.
@hyunsik
Copy link
Copy Markdown
Member

hyunsik commented Jul 11, 2014

+1

The travis test result is failed due to 'No output' in the last 10 minutes. But, I manually verified 'mvn clean install'. The latest bug fix also looks nice.

@asfgit asfgit closed this in 95292d2 Jul 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants